Code Review on GitHub
📌 Covered in this chapter:
Inline Comments · Suggestions · Approving vs Requesting Changes · Resolving Conversations
Give and receive effective code review feedback on GitHub pull requests using inline comments and suggestions.
1Code Review on GitHub — What You'll Learn
Give and receive effective code review feedback on GitHub pull requests using inline comments and suggestions.
Here's everything this chapter covers, in the order you'll learn it:
- What code review is for
- Reviewing a diff on GitHub
- Leaving inline comments on specific lines
- Making a code suggestion GitHub can auto-apply
- Approving a pull request
- Requesting changes
- Building a personal review checklist
- Giving friendly, constructive feedback
- Responding to review comments as the author
- Updating a pull request after feedback
- Resolving finished conversations
- Requesting a re-review
2Best Practices & Common Pitfalls
💡 Key things to remember:
- Frame review comments around the code, not the person ('this could cause a null error' rather than 'you made a mistake') — it keeps reviews collaborative rather than confrontational.
❓ Frequently Asked Questions (FAQ)
Q What's the most important thing to understand about code review on github?
Focus on: Inline Comments · Suggestions · Approving vs Requesting Changes · Resolving Conversations. These are the core building blocks this chapter's examples are built around, and they show up repeatedly in later chapters of this course.
Q Is code review on github something I'll use often in real projects?
Yes — every concept in this chapter reflects a real, everyday part of professional Git and GitHub workflows, not just a theoretical exercise.